Open
Conversation
Use toThrowError instead of toThrow for Jasmine compatibility, check err.message instead of err for rejected promises, and add missing catch clause to prevent unhandled rejection warning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e handling - Replace Jasmine 1.x waitsFor/runs with modern done callback pattern in common.js login() and monaca.spec.js beforeEach blocks - Fix logout test to use getData() synchronously (returns value, not promise) - Add .catch with done.fail() to prevent unhandled promise rejections - Add 30s timeout to downloadFile failure tests (retry logic exceeds default 5s) - Fix logout() to return setData() promise so callers await cleanup - Set clientType to 'cli' in Monaca constructor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When getProjects fails or times out, dependent cloneProject tests now skip gracefully instead of failing with a null projectId. Also adds a test case for cloneProject behavior when projectId is unavailable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rder Separate 'Test setup' describe block caused failures when Jasmine ran tests in random order. Move login/getProjects into beforeAll within the cloneProject describe block and remove the now-unnecessary setupFailed guards and failure-scenario describe block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cloneProject.spec.jsと同様に、別のdescribeブロックにあったログイン・クローン処理を beforeAllに移動し、テストの実行順序に依存しないようにした。 エラーハンドリングも追加。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- buildProject: Setupテスト用describeを廃止しbeforeAllに統合 - monaca: getProjects/downloadFile/uploadFileのbeforeEachをbeforeAllに変更 - 空プロジェクト時のガードとエラーハンドリングを追加 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://monaca.atlassian.net/browse/MN-6079?atlOrigin=eyJpIjoiMDMyN2YxMDI0ZGE2NDM1MmI4NjgyYjNjZTdkZTNjNzEiLCJwIjoiaiJ9
概要
テストコードの修正と安定化を行いました。主に以下の問題に対処しています。
変更対象
変更内容の詳細
非推奨のwaitsFor/runsを削除し、async/awaitベースのPromiseハンドリングに修正。clientTypeの設定とcatch句を追加
セットアップ処理をbeforeAllに移動し、テストの実行順序に依存しない構成に変更
テスト計画