Merged
Conversation
- Add Detekt for static code analysis with Google-style configuration - Add ktlint for Kotlin code formatting (Android style) - Configure Android Lint with baseline for existing issues - Add .editorconfig for consistent code style - Auto-format codebase with ktlint - Generated baselines for gradual improvement
- Fix ktlint formatting issues (trailing commas, line length, braces) - Fix detekt issues (unused properties, parameters, imports, braces) - Remove unused code (formatTime function, FRAME_DISPLAY_INTERVAL_MS) - Use specific IOException instead of generic Exception in SSEService - Add @Suppress annotations for required but unused Compose parameters - Adjust detekt thresholds for Compose patterns (complexity, params) - Remove lint-baseline.xml and detekt baseline.xml - Add lint.xml for NewApi suppression in generated UniFFI code - Configure .editorconfig to disable conflicting ktlint rules All checks now pass: ktlint, detekt, Android Lint Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add Clean Architecture foundation for the Android app: Core: - AppResult<T> sealed class for error handling - AppError sealed class hierarchy for typed errors - DispatcherProvider interface for testable coroutines Domain Layer: - Repository interfaces: ConversationRepository, PadRepository, SettingsRepository - Service interfaces: CryptoService, RelayService, RealtimeService - Use cases: BurnConversationUseCase, RegisterConversationUseCase, CheckBurnStatusUseCase Data Layer: - Repository implementations wrapping existing services - Service implementations wrapping existing core services DI: - DataModule, DomainModule, RepositoryModule for Hilt bindings UI Components: - Extracted ColorButton and MnemonicWord to common components - Extracted CeremonyStatusContent and PadSizeSelection components Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tmihalicka
force-pushed
the
feat/android-fixes
branch
from
2228e72 to
c99837e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.