The start point for the C3P Community Cloud-Convection Parameterization and Merging with MONAN v1.4.1-rc

[saulorfreitas]

**** Attention: disregard all files inside the “own_...” directories **** . Those files are only for my own work.
This new version of GF contains:

1. Speed up by about 7%
2. Cleanup to become the initial version of the C3P Community Cloud-Convection Parameterization. Joint development between INPE and NOAA/GSL. Removed files not needed anymore.
3. Adding effects of PCW (Neelin et al. 2009) and vertical shear of horizontal wind on the entrainment rate. This should improve model simulations of MCSs
4. Additional trigger function based on Xie et al 2019.
5. Additional comments and references.
6. This version defaults to namelist version 1.6.

[joaomas]

Assigned #791 for testing.

1. Test Compile - PASS
2. Test Execution - PASS
3. Test 240h FCST 0Z and 12Z - PASS
4. Test 6h debug flag - FAILED
5. Basic compare with last version.

[joaomas]

@saulorfreitas the test with the debug flag turned on an error, the message is:

"model.e.XXX"

Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.

Backtrace for this error:
#0  0x146389f970c0 in ???
#1  0x146389f962f5 in ???
#2  0x146389350c1f in ???
#3  0xe53c11 in set_entr_detr_rates
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/physics/physics_monan/module_cu_gf.monan.F:7097
#4  0xf1906d in cup_gf
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/physics/physics_monan/module_cu_gf.monan.F:1897
#5  0xff2738 in __module_cu_gf_monan_MOD_cu_gf_monan_driver
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/physics/physics_monan/module_cu_gf.monan.F:1094
#6  0xd1d2d3 in __mpas_atmphys_driver_convection_MOD_driver_convection
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/physics/mpas_atmphys_driver_convection.F:890
#7  0x719fae in __mpas_atmphys_driver_MOD_physics_driver._omp_fn.11
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/physics/mpas_atmphys_driver.F:353
#8  0x1463899cf4c1 in ???
#9  0x71788f in __mpas_atmphys_driver_MOD_physics_driver
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/physics/mpas_atmphys_driver.F:353
#10  0x62063f in __atm_core_MOD_atm_do_timestep
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/mpas_atm_core.F:998
#11  0x622fa0 in __atm_core_MOD_atm_core_run
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/core_atmosphere/mpas_atm_core.F:721
#12  0x407ee5 in __mpas_subdriver_MOD_mpas_run
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/driver/mpas_subdriver.F:416
#13  0x4066ae in mpas
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/driver/mpas.F:20
#14  0x406719 in main
at /mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/sources/MONAN-Model_develop/src/driver/mpas.F:10
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun noticed that process rank 57 with PID 0 on node n13 exited on signal 8 (Floating point exception).

[joaomas]

@saulorfreitas the test folder is:

"/mnt/beegfs/joao.messias/pr_teste_debug/scripts_CD-CT/dataout/"

Thanks.

[saulorfreitas]

@joaomas bug fixed. Please, check my develop. Do I need to make a new pull request?

[saulorfreitas]

Ola João, Corrigi o bug. Era divisão zero/zero. Já atualizei a minha develop. Obrigado e desculpe-me por este bug. Saulo

[joaomas]

Testing again...

[joaomas]

The files in the folder "/own_namelist_monan" and "src/core_atmosphere/physics/physics_monan/own_files/module_cu_gf.monan.F_1.3" e "src/core_atmosphere/physics/physics_monan/own_files/module_cu_gf.monan.F_1.4" need to be removed by you.

instructions on this sent by email.

[joaomas]

1. Test Compile: OK
2. Tests Execution: OK
   2.1. Test 1: 20250716 12Z - 240h FCST - 512c8n: OK
   2.2. Test 2: 20250717 12Z - 240h FCST - 256c4n: OK
   2.3. Test 3: 20250716 12Z - flag "debug=true" - 6h FCST - 512c8n: OK
   2.4. Test 4: 20250717 12Z - flag "debug=true" - 6h FCST - 2562c4n: OK
   2.5. Test 5: 20240420 00Z - first day P1 - 240h FCST - 512c8n: OK
3. Compare with last version: OK
4. DTN-01 Check: not applied yet

Pull Request approved.