Conversation
AvnerMaster
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derive rollup
externallist automatically frompackage.jsoninstead of maintaining a hardcoded duplicate list.Why
Previously, the
externalarray inrollup.config.jswas a hardcoded list (['@mondaydotcomorg/api', 'zod', 'zod-to-json-schema']). This meant every time a dependency was added topackage.json, it also had to be manually added to the rollup config — and forgetting to do so would silently bundle it instead of externalizing it (this was already the case foraxiosandjsonwebtoken).Now
externalis derived frompkg.dependenciesandpkg.peerDependencies, so new dependencies are automatically externalized with no extra step.Note on
createRequireWe use
createRequireto loadpackage.jsonbecause this project uses Rollup 2, which doesn't support JSON import assertions (import pkg from './package.json' with { type: 'json' }). This is the standard Node.js workaround for importing JSON in ES modules.