Merged
Conversation
Calls the new LSPS4 process_pending_htlcs() method on the existing 5-second HTLC expiry timer. This retries forwarding HTLCs that were deferred at peer_connected time because the channel was not yet usable (channel_reestablish still in progress).
Both process_pending_htlcs and handle_expired_htlcs shared a single 5-second sleep, coupling two concerns with very different latency requirements. Expiry checks are distributed-clock housekeeping where seconds don't matter. Pending HTLC retries gate payment completion for serverless SDK clients that reconnect briefly (~20s) during webhook-driven flows — every extra second of retry latency is a second the payer is staring at a spinner. Splitting them into independent select! arms requires switching from sleep to tokio::time::interval. With sleep, the losing arm in a select! is cancelled and recreated each iteration — the 1s pending-HTLC sleep would fire every loop, resetting the 5s expiry sleep before it ever completes, starving handle_expired_htlcs entirely. interval maintains its deadline across select! iterations so both timers tick independently. MissedTickBehavior::Skip avoids burst catch-up if a handler blocks longer than its interval.
martinsaposnic
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally lost these commits. Re-applying