Decouple LSPS4 webhooks from liquidity loop#22
Merged
amackillop merged 1 commit intolsp-0.7.0from Apr 21, 2026
Merged
Conversation
Send LSPS4 wake-up webhooks in the background instead of awaiting the HTTP response on the liquidity event loop. Direct webhook delivery was meant to reduce wake-up latency, but waiting for the response made unrelated liquidity work depend on the client's webhook handler. When that handler keeps the request open while the node wakes and starts processing payments, follow-up actions such as opening a channel can be delayed behind the webhook. Keep a long timeout on the background request as cleanup for genuinely stuck connections. The timeout is not part of LSPS4 control flow; it is there to bound resource usage while still treating the webhook as best-effort.
martinsaposnic
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send LSPS4 wake-up webhooks in the background instead of awaiting the HTTP response on the liquidity event loop.
Direct webhook delivery was meant to reduce wake-up latency, but waiting for the response made unrelated liquidity work depend on the client's webhook handler. When that handler keeps the request open while the node wakes and starts processing payments, follow-up actions such as opening a channel can be delayed behind the webhook.
Keep a long timeout on the background request as cleanup for genuinely stuck connections. The timeout is not part of LSPS4 control flow; it is there to bound resource usage while still treating the webhook as best-effort.