Bump rust-lightning for peer_connected race condition diagnostics#8
Merged
martinsaposnic merged 1 commit intolsp-0.7.0from Mar 2, 2026
Merged
Conversation
Update rust-lightning rev to 145438f9f which adds diagnostic logging across LSPS4 service and LDK core to prove and quantify the peer_connected / ChannelReestablish race condition. See: moneydevkit/rust-lightning#3
martinsaposnic
force-pushed
the
bump-rust-lightning-race-diagnostics
branch
from
af5d838 to
427a91f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-lightningdependency from68c0e4dto145438f9fto pick up diagnostic logging for the peer_connected / ChannelReestablish race conditionWhat changed upstream
PR: moneydevkit/rust-lightning#3
Production logs show HTLCs silently failing because
peer_connectedfires beforechannel_reestablishcompletes.forward_intercepted_htlcchecksis_usable()(passes) butsend_htlclater checksis_peer_disconnected()(fails). The HTLC is failed back to the payer with no LSPS4-level error.The upstream PR adds end-to-end logging at every step:
peer_connected,peer_disconnected,channel_ready,htlc_intercepted,execute_htlc_actions,calculate_htlc_actions,handle_expired_htlcs- all now log channelis_usable/is_channel_readystateforward_intercepted_htlc: logsis_usablevsis_livevsis_connected, emits WARNING whenis_usable && !is_livechannel_reestablish: logs whenclear_peer_disconnected()fires (channel becomes live)send_htlc: logs when HTLC is rejected due topeer_disconnectedprocess_forward_htlcs: logs channel liveness beforequeue_add_htlcGrafana queries after deploying
forward_intercepted_htlc.*is_usable: true.*is_live: falsesend_htlc: REJECTING HTLC.*peer_disconnectedpeer_connected.*is_usable: falsechannel_reestablish: clearing peer_disconnectedTest plan
cargo build- clean (warnings are pre-existing)