Skip to content

doc: Add link to API reference + React example in README #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2022
Merged

doc: Add link to API reference + React example in README #61

merged 2 commits into from
Mar 7, 2022

Conversation

@khanguslee
Copy link
Collaborator

@khanguslee khanguslee commented Mar 4, 2022

Quick PR to add links to:

  • npm page that has an exhaustive list of all the api methods documented nicely
  • An existing React example for people who want to use the the charts embed SDK in a React application.

@khanguslee khanguslee self-assigned this Mar 4, 2022
mongo-J
mongo-J approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@mongo-J mongo-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kristinamongo
kristinamongo approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@kristinamongo kristinamongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaay 🥳 🥳 👏

@khanguslee khanguslee merged commit fa47084 into master Mar 7, 2022
@khanguslee khanguslee deleted the doc/better-links-to-docs branch March 7, 2022 00:34
@khanguslee khanguslee mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mongo-J mongo-J mongo-J approved these changes

@kirangp kirangp Awaiting requested review from kirangp

+1 more reviewer

@kristinamongo kristinamongo kristinamongo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@khanguslee khanguslee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khanguslee @kristinamongo @mongo-J