COMPASS-1183 backport COMPASS-810 #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add extended query bar to explain tab + use bumped data-service * add support for get indexes from explain view * fix incorrect option key for projection * add support + test for projection from explain * fix tests for travis issues * rebase on master + fix explain sort test # Conflicts: # test/functional/support/packages/spectron-explain.js
rueckstiess
changed the title
rueckstiess
force-pushed
the
COPMASS-1181-backport-COMPASS-810
branch
from
ac9a1c7 to
d89ddac
Compare
added 2 commits
May 24, 2017 16:30
* add extended query bar to explain tab + use bumped data-service * add support for get indexes from explain view * fix incorrect option key for projection * add support + test for projection from explain * fix tests for travis issues * rebase on master + fix explain sort test # Conflicts: # test/functional/support/packages/spectron-explain.js
pzrq
approved these changes
May 24, 2017
Contributor
pzrq
left a comment
pzrq
left a comment
There was a problem hiding this comment.
LGTM 👍
Tests basically pass for me on local (just #899 being an issue for me on 1.7-releases), which Travis also confirm as OK.
This also looks like a prerequisite to seeing COMPASS-1144 backported, and is definitely an improvement over what was previously present on 1.7-releases.
Contributor
Author
|
thanks @pzrq. Tests now passing on Travis, too, after adding all the required spectron helpers. Yes, next is backport of COMPASS-1144. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the extended query options for the Explain view COMPASS-810.