fix(deps): bump shell-bson-parser to 1.1.2 MONGOSH-1859 #6169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Aug 29, 2024
package-lock.json
Outdated
| "node": ">=6.0.0" | ||
| } | ||
| }, | ||
| "packages/compass-aggregations/node_modules/@mongodb-js/shell-bson-parser": { |
Collaborator
There was a problem hiding this comment.
Looks a bit suspicious that these got un-hoisted. Are there packages that still depend on the other version in the monorepo? 🤔
Collaborator
Author
There was a problem hiding this comment.
Huh! Great catch, I didn't notice at all, and I don't know why npm did this, I literally only bumped the versions in the packages and ran "npm install". And there aren't any other dependencies on these packages in Compass...
I undid this but will also keep an eye on this, this just seems like something that shouldn't be happening 🤔
Collaborator
There was a problem hiding this comment.
Might be some change in algo in some recent npm version maybe 🤔
gribnoysup
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes