feat: add sharded state COMPASS-8279 #6304

paula-stacho · 2024-09-30T15:26:33Z

Description

show sharded state to the user
shows zone table (without search & collapse - follow up in https://jira.mongodb.org/browse/COMPASS-8336)
it lets user to unmanage the namespace
also sets states like SHARD_KEY_INVALID, SHARD_KEY_MISMATCH or SHARDING_ERROR, but doesn't add the UI for them (will be added in https://jira.mongodb.org/browse/COMPASS-8278 and https://jira.mongodb.org/browse/COMPASS-8349)

Checklist

New tests and/or benchmarks are included
Documentation is changed or added
I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

Bugfix
New feature
Dependency update
Misc

Open Questions

Dependents

Types of changes

Backport Needed
Patch (non-breaking change which fixes an issue)
Minor (non-breaking change which adds functionality)
Major (fix or feature that would cause existing functionality to change)

packages/atlas-service/src/make-automation-agent-op-request.ts

packages/compass-global-writes/src/components/states/shard-key-correct.tsx

gribnoysup · 2024-10-08T07:54:20Z

packages/compass-global-writes/tests/create-store.tsx

+  const store = setupStore(options, services, connectionInfo);
+  return renderWithActiveConnection(
+    <Provider store={store}>{component}</Provider>,
+    connectionInfo
+  );


Just FYI, we specifically added these helpers so you don't need to manually wire providers and run activate methods

packages/compass-global-writes/src/store/reducer.ts

packages/compass/src/main/application.ts

packages/compass-global-writes/src/store/reducer.ts

gribnoysup · 2024-10-08T08:22:23Z

GitHub collapsed the reducer file and I only looked at the changes there today while revieweing again, sorry for not including this in my initial review

…-correct.tsx Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>

packages/compass-global-writes/src/components/states/shard-key-correct.tsx

gribnoysup · 2024-10-09T07:34:11Z

packages/compass-global-writes/src/store/index.spec.ts

+        },
+      });
+      await store.dispatch(fetchClusterShardingData());
+      // expect(store.getState().status).to.equal('SHARD_KEY_CORRECT'); //  no idea why this does not work


Is the state not matching or the check? What state do you see here? (we probably want to either remove this comment altogether or resolve, a bit weird to just leave this comment 🙂)

I was seeing NOT_READY. Putting the check behind waitFor helped, but I'm not sure why it was needed 🤔

I guess it's because this fetch action is not the one that actually will update the state, and the one that will is not awaited inside this one:

Not sure if it's this intentional or not

ah right! I was looking at this code and read it wrong 🤦 outside of tests it currently doesn't make difference if we wait for this one, since the fetchClusterShardingData is not awaited.

packages/compass-global-writes/src/store/reducer.ts

Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>

setup sharded state

9c255d6

paula-stacho added the wip label Sep 30, 2024

github-actions bot added the feat label Sep 30, 2024

gribnoysup reviewed Sep 30, 2024

View reviewed changes

packages/atlas-service/src/make-automation-agent-op-request.ts Outdated Show resolved Hide resolved

paula-stacho force-pushed the sharded-state branch 2 times, most recently from cebd5db to 9c255d6 Compare October 1, 2024 11:26

paula-stacho added 5 commits October 1, 2024 13:27

Merge branch 'main' into sharded-state

c8c1ade

small fixes

1771242

some more fixes + tests

b62fb1c

more tests

9da1f6b

update tests

3709b00

paula-stacho force-pushed the sharded-state branch from d6f86a3 to 3709b00 Compare October 4, 2024 09:56

lodash

7cb7a51

paula-stacho added the no release notes Fix or feature not for release notes label Oct 7, 2024

paula-stacho added 3 commits October 7, 2024 11:20

logId

e6fb8e9

Merge branch 'main' into sharded-state

6f9e7b2

logId

facd106

paula-stacho marked this pull request as ready for review October 7, 2024 09:33

paula-stacho removed the wip label Oct 7, 2024