Skip to content

Conversation

@mabaasit
Copy link
Collaborator

Generate vulnerability report task is failing on CI and requires to bump cross-spawn to latest in addition to electron update (#6428)

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 11, 2024
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do the update with npm update or differently? I still see some transitive deps that would be bundled with the app using the 7.0.3:

image

@mabaasit
Copy link
Collaborator Author

Did you do the update with npm update or differently? I still see some transitive deps that would be bundled with the app using the 7.0.3:

Just the regular npm install for each package where we needed dep update. Yeah, i was a bit confused with lock file changes that were generated as well. Just ran npm update in 89501a9

@mabaasit mabaasit merged commit c96156a into main Nov 11, 2024
30 checks passed
@mabaasit mabaasit deleted the bump-cross-spawn branch November 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants