fix(compass-global-writes): make global writes tab not appear for readonly and config/local/admin collections COMPASS-8447 #6479
Conversation
djechlin-mongodb
added
fix
no release notes
| const isGlobalWritesSupported = | ||
| useConnectionSupports(connectionInfoRef.current.id, 'globalWrites') && | ||
| !props.isReadonly && | ||
| !['config', 'local', 'admin'].includes(props.namespace.split('.')[0]); |
There was a problem hiding this comment.
We use mongodb-ns package for this. You'd want to check the specialish prop on the parsed namespace here
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
I'd probably suggest adding either a plugin level unit test or an e2e test for this, but otherwise code looks good!
Looks like there's no tests set up on this already so there's a bit of work to scaffold them. I discussed with Paula, we think it's just a lot to set up right now so going with merging. |
djechlin-mongodb
deleted the
COMPASS-8447-views-internal-no-global-writes
branch
Fair enough, but FWIW the e2e one is then probably the easiest to add, you would only need to open collection by name in any existing e2e test and check that the tab is not there, not extra setup needed |
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes