chore(components): refactor InteractivePopover to take a type argument for the trigger element
#6495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow-up to this #6486 (comment), I suggest adding a type argument to the
InteractivePopoverto specify the concreteHTMLElementused when declaring the type of therefpassed through thetriggercallback.We can't just pass
React.Ref<HTMLElement>as that (as an example) isn't possible to pass viarefto a<button />:☝️ yields this TS error related to the
refprop:Checklist
Motivation and Context
Open Questions
Dependents
Types of changes