Skip to content

fix(web, connections): filter out paused clusters; cleanup connections on plugin deactivate COMPASS-8510 CLOUDP-284226 #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix(web, connections): filter out paused clusters; cleanup connections on plugin deactivate COMPASS-8510 CLOUDP-284226 #6500

merged 2 commits into from
Nov 19, 2024
+62 −9

Conversation

@gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Nov 15, 2024

Two small fixes related to compass-web:

  • cleanup connections when plugin is deactivated, doesn't really affect compass, but when navigating to other pages in DE, connections stay open CLOUDP-284226
  • filter out paused clusters when building a list of connections, we can't really connect to those and they are missing important metadata COMPASS-8510

@github-actions github-actions bot added the fix label Nov 15, 2024
@gribnoysup gribnoysup added the no release notes Fix or feature not for release notes label Nov 15, 2024
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 18, 2024
@gribnoysup gribnoysup merged commit 8512aa7 into main Nov 19, 2024
25 of 31 checks passed
@gribnoysup gribnoysup deleted the cloud-284226-compass-8510 branch November 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy approved these changes

Assignees

No one assigned

Labels

fix no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gribnoysup @Anemy