chore(compass-web): use ccs for atlas sandbox instead of local proxy COMPASS-8693 #6570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
Author
|
EDIT: CLOUDP-286880 is resolved, so should be able to proceed with this now |
Collaborator
Author
|
Manually started a task to check that the test-web-with-atlas-cloud will pass as this task doesn't run on PRs automatically: https://spruce.mongodb.com/version/677f902afc201800075559d4/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC (it's green) |
lerouxb
reviewed
Jan 9, 2025
| return electronProxyRemote; | ||
| } | ||
|
|
||
| debug('Waiting for x509 cert to propagate to Atlas clusters ...'); |
lerouxb
reviewed
Jan 9, 2025
|
|
||
| const WEBSOCKET_PROXY_PORT = process.env.COMPASS_WEBSOCKET_PROXY_PORT | ||
| ? Number(process.env.COMPASS_WEBSOCKET_PROXY_PORT) | ||
| : 1337; |
lerouxb
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch switches the compass-web sandbox to use ccs instead of manually replicating the similar connection logic (creating a temp user and issuing a cert), this comes with two benefits: