feat(e2e): smoketest macOS .dmg files COMPASS-8709 #6579
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { spawn } from 'child_process'; | ||
| import type { SpawnOptions } from 'child_process'; | ||
|
|
||
| export function execute( | ||
| command: string, | ||
| args: string[], | ||
| options?: SpawnOptions | ||
| ): Promise<void> { | ||
| return new Promise((resolve, reject) => { | ||
| console.log(command, ...args); | ||
| const p = spawn(command, args, { | ||
| stdio: 'inherit', | ||
| ...options, | ||
| }); | ||
| p.on('error', (err: any) => { | ||
| reject(err); | ||
| }); | ||
| p.on('close', (code: number | null, signal: NodeJS.Signals | null) => { | ||
| if (code !== null) { | ||
| if (code === 0) { | ||
| resolve(); | ||
| } else { | ||
| reject( | ||
| new Error(`${command} ${args.join(' ')} exited with code ${code}`) | ||
| ); | ||
| } | ||
| } else { | ||
| if (signal !== null) { | ||
| reject( | ||
| new Error( | ||
| `${command} ${args.join(' ')} exited with signal ${signal}` | ||
| ) | ||
| ); | ||
| } else { | ||
| // shouldn't happen | ||
| reject( | ||
| new Error( | ||
| `${command} ${args.join(' ')} exited with no code or signal` | ||
| ) | ||
| ); | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import path from 'path'; | ||
| import { existsSync } from 'fs'; | ||
| import type { InstalledAppInfo, Package } from './types'; | ||
| import { execute } from './helpers'; | ||
|
|
||
| export async function installMacDMG( | ||
| appName: string, | ||
| { filepath }: Package | ||
| ): Promise<InstalledAppInfo> { | ||
| const fullDestinationPath = `/Applications/${appName}.app`; | ||
|
|
||
| if (existsSync(fullDestinationPath)) { | ||
| // Would ideally just throw here, but unfortunately in CI the mac | ||
| // environments aren't all clean so somewhere we have to remove it anyway. | ||
| console.log(`${fullDestinationPath} already exists. Removing.`); | ||
| await execute('rm', ['-rf', fullDestinationPath]); | ||
| } | ||
|
|
||
| await execute('hdiutil', ['attach', filepath]); | ||
| try { | ||
| await execute('cp', [ | ||
| '-Rp', | ||
| `/Volumes/${appName}/${appName}.app`, | ||
| '/Applications', | ||
| ]); | ||
| } finally { | ||
| await execute('hdiutil', ['detach', `/Volumes/${appName}`]); | ||
| } | ||
|
|
||
| // get debug output so we can see that it copied everything with the correct | ||
| // permissions | ||
| await execute('ls', ['-laR', `/Applications/${appName}.app`]); | ||
|
|
||
| // see if the executable will run without being quarantined or similar | ||
| await execute(`/Applications/${appName}.app/Contents/MacOS/${appName}`, [ | ||
| '--version', | ||
| ]); | ||
|
|
||
| if (process.env.HOME) { | ||
| const settingsDir = path.resolve( | ||
| process.env.HOME, | ||
| 'Library', | ||
| 'Application Support', | ||
| appName | ||
| ); | ||
|
|
||
| if (existsSync(settingsDir)) { | ||
| console.log(`${settingsDir} already exists. Removing.`); | ||
| await execute('rm', ['-rf', settingsDir]); | ||
| } | ||
| } | ||
|
|
||
| return Promise.resolve({ | ||
| appName, | ||
| appPath: `/Applications/${appName}.app`, | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| export type Package = { | ||
| filename: string; | ||
| filepath: string; | ||
| }; | ||
|
|
||
| export type InstalledAppInfo = { | ||
| appName: string; | ||
| appPath: string; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Let's see if we really need this" and then forget about it for a week 🤦