Skip to content

chore(e2e): Extend ChromedriverOptions instead of type-asserting any #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore(e2e): Extend ChromedriverOptions instead of type-asserting any #6589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/compass-e2e-tests/helpers/compass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@ const packageCompassAsync = promisify(packageCompass);
// should we test compass-web (true) or compass electron (false)?
export const TEST_COMPASS_WEB = isTestingWeb();

// Extending the WebdriverIO's types to allow a verbose option to the chromedriver
declare global {
// eslint-disable-next-line @typescript-eslint/no-namespace
namespace WebdriverIO {
interface ChromedriverOptions {
verbose?: boolean;
}
}
}

/*
A helper so we can easily find all the tests we're skipping in compass-web.
Reason is there so you can fill it in and have it show up in search results
Expand Down Expand Up @@ -663,10 +673,7 @@ async function startCompassElectron(
let browser: CompassBrowser;

try {
// webdriverio's type is wrong for
// options.capabilities['wdio:chromedriverOptions'] and it doesn't allow
// verbose even though it does work
browser = (await remote(options as any)) as CompassBrowser;
browser = (await remote(options)) as CompassBrowser;
} catch (err) {
debug('Failed to start remote webdriver session', {
error: (err as Error).stack,
Expand Down
Loading