Skip to content

fix: catch parse error on multi insert #6815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix: catch parse error on multi insert #6815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/compass-crud/src/stores/crud-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,19 +1345,19 @@ class CrudStoreImpl
* Insert a single document.
*/
async insertMany() {
const docs = HadronDocument.FromEJSONArray(
this.state.insert.jsonDoc ?? ''
).map((doc) => doc.generateObject());
this.track(
'Document Inserted',
{
mode: this.state.insert.jsonView ? 'json' : 'field-by-field',
multiple: docs.length > 1,
},
this.connectionInfoRef.current
);

try {
const docs = HadronDocument.FromEJSONArray(
this.state.insert.jsonDoc ?? ''
).map((doc) => doc.generateObject());
this.track(
'Document Inserted',
{
mode: this.state.insert.jsonView ? 'json' : 'field-by-field',
multiple: docs.length > 1,
},
this.connectionInfoRef.current
);

await this.dataService.insertMany(this.state.ns, docs);
// track mode for analytics events
const payload = {
Expand Down
Loading