chore(compass-assistant): fix onError and add error handling tests COMPASS-9384 #7438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
requested review from
Copilot and
gribnoysup
and removed request for
Copilot
gagik
force-pushed
the
gagik/telemetry-error
branch
from
4dc28df to
4df81ea
Compare
gagik
changed the title
gagik
force-pushed
the
gagik/telemetry-error
branch
from
4df81ea to
a3cfd28
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with error handling in the compass-assistant module by moving the onError callback from the component level to the transport level and adding comprehensive error handling tests.
- Moved error tracking from
useChathook to the transport layer increateDefaultChat - Added test utilities for simulating broken transports and chats
- Added comprehensive error handling test coverage for both component and provider levels
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-assistant/test/utils.tsx | Added helper functions for creating broken transports and chats for error testing |
| packages/compass-assistant/src/components/assistant-chat.tsx | Removed duplicate onError handler from useChat hook |
| packages/compass-assistant/src/components/assistant-chat.spec.tsx | Updated test structure and added error handling test coverage |
| packages/compass-assistant/src/compass-assistant-provider.tsx | Refactored chat creation and moved error handling to transport level |
| packages/compass-assistant/src/compass-assistant-provider.spec.tsx | Added error handling tests and fixed test structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/compass-assistant/src/compass-assistant-provider.spec.tsx
Outdated
Show resolved
Hide resolved
lerouxb
approved these changes
Oct 10, 2025
….tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the previous way of setting onError twice did not play together too well.