Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

Description

This is a revert commit of 52f148e
(without package.json and package-lock.json as we're only moving forward with the versions 😁 )
We have a couple of things we need to resolve before the functionality is usable.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings October 16, 2025 10:04
@paula-stacho paula-stacho requested a review from a team as a code owner October 16, 2025 10:04
@paula-stacho paula-stacho requested a review from nbbeeken October 16, 2025 10:04
@paula-stacho paula-stacho added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Oct 16, 2025
@github-actions github-actions bot added the fix label Oct 16, 2025
@paula-stacho paula-stacho added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Oct 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the DM (Data Model) collapse functionality that was previously introduced. The changes remove the ability to expand/collapse collections in the data modeling diagram view by eliminating the isExpanded property and related toggle functionality throughout the codebase.

Key Changes:

  • Removed isExpanded property from collection data structures and schemas
  • Eliminated toggleCollectionExpanded action and ToggleExpandCollection edit type
  • Simplified field rendering logic to always show all fields regardless of depth
  • Cleaned up test fixtures and test cases to remove isExpanded references

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/compass-data-modeling/test/fixtures/data-model-with-relationships.json Removed isExpanded: false properties from test fixture collections
packages/compass-data-modeling/src/utils/nodes-and-edges.ts Removed expand/collapse logic from field generation functions and simplified type definitions
packages/compass-data-modeling/src/utils/nodes-and-edges.spec.ts Updated test expectations to reflect removal of path property and function rename
packages/compass-data-modeling/src/store/diagram.ts Removed toggleCollectionExpanded action and isExpanded property handling
packages/compass-data-modeling/src/store/diagram.spec.ts Removed isExpanded from test data model definitions
packages/compass-data-modeling/src/store/apply-edit.ts Removed ToggleExpandCollection edit case handler
packages/compass-data-modeling/src/store/analysis-process.ts Removed isExpanded from initial layout generation
packages/compass-data-modeling/src/services/data-model-storage.ts Removed isExpanded from collection schema and edit schema
packages/compass-data-modeling/src/components/saved-diagrams-list.spec.tsx Removed isExpanded from test storage items
packages/compass-data-modeling/src/components/diagram-editor.tsx Removed expand/collapse event handlers and related functionality
packages/compass-data-modeling/src/components/diagram-editor.spec.tsx Removed isExpanded from test storage items
packages/compass-data-modeling/src/components/diagram-card.spec.tsx Removed isExpanded from test data model
packages/compass-components/src/index.ts Removed FieldId type export

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codeowners-service-app
Copy link

Assigned himanshusinghs for team compass-developers because nbbeeken is out of office.

@paula-stacho paula-stacho requested a review from addaleax October 16, 2025 10:08
@paula-stacho paula-stacho merged commit 1507c9f into main Oct 16, 2025
173 of 184 checks passed
@paula-stacho paula-stacho deleted the temporarily-revert-collapse branch October 16, 2025 13:26
paula-stacho added a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release fix no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants