-
Notifications
You must be signed in to change notification settings - Fork 244
fix: temporarily revert DM collapse functionality #7461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he node COMPASS-9504 (#7455)" This reverts commit 52f148e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the DM (Data Model) collapse functionality that was previously introduced. The changes remove the ability to expand/collapse collections in the data modeling diagram view by eliminating the isExpanded property and related toggle functionality throughout the codebase.
Key Changes:
- Removed
isExpandedproperty from collection data structures and schemas - Eliminated
toggleCollectionExpandedaction andToggleExpandCollectionedit type - Simplified field rendering logic to always show all fields regardless of depth
- Cleaned up test fixtures and test cases to remove
isExpandedreferences
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-data-modeling/test/fixtures/data-model-with-relationships.json | Removed isExpanded: false properties from test fixture collections |
| packages/compass-data-modeling/src/utils/nodes-and-edges.ts | Removed expand/collapse logic from field generation functions and simplified type definitions |
| packages/compass-data-modeling/src/utils/nodes-and-edges.spec.ts | Updated test expectations to reflect removal of path property and function rename |
| packages/compass-data-modeling/src/store/diagram.ts | Removed toggleCollectionExpanded action and isExpanded property handling |
| packages/compass-data-modeling/src/store/diagram.spec.ts | Removed isExpanded from test data model definitions |
| packages/compass-data-modeling/src/store/apply-edit.ts | Removed ToggleExpandCollection edit case handler |
| packages/compass-data-modeling/src/store/analysis-process.ts | Removed isExpanded from initial layout generation |
| packages/compass-data-modeling/src/services/data-model-storage.ts | Removed isExpanded from collection schema and edit schema |
| packages/compass-data-modeling/src/components/saved-diagrams-list.spec.tsx | Removed isExpanded from test storage items |
| packages/compass-data-modeling/src/components/diagram-editor.tsx | Removed expand/collapse event handlers and related functionality |
| packages/compass-data-modeling/src/components/diagram-editor.spec.tsx | Removed isExpanded from test storage items |
| packages/compass-data-modeling/src/components/diagram-card.spec.tsx | Removed isExpanded from test data model |
| packages/compass-components/src/index.ts | Removed FieldId type export |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Assigned |
This reverts commit 1507c9f.
Description
This is a revert commit of 52f148e
(without
package.jsonandpackage-lock.jsonas we're only moving forward with the versions 😁 )We have a couple of things we need to resolve before the functionality is usable.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes