Skip to content

fix(compass-connections-navigation): disable dropping database in readonly in the context menu COMPASS-10058 #7557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

fix(compass-connections-navigation): disable dropping database in readonly in the context menu COMPASS-10058 #7557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,10 +1064,13 @@ describe('ConnectionsNavigationTree', function () {
const contextMenu = screen.getByTestId('context-menu');

// Check that write actions are not present in read-only mode
expect(() => within(contextMenu).getByText('Create collection')).to
.throw;
expect(() => within(contextMenu).getByText('Create database')).to.throw;
expect(() => within(contextMenu).getByText('Drop database')).to.throw;
expect(() =>
within(contextMenu).getByText('Create collection')
).to.throw();
expect(() =>
within(contextMenu).getByText('Create database')
).to.throw();
expect(() => within(contextMenu).getByText('Drop database')).to.throw();

// Check that read-only actions are still present
expect(within(contextMenu).getByText('View performance metrics')).to.be
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-connections-navigation/src/item-actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export const databaseContextMenuActions = ({
icon: 'Plus',
label: 'Create database',
},
hasWriteActionsDisabled && canDeleteDatabase
hasWriteActionsDisabled || !canDeleteDatabase
? null
: {
action: 'drop-database',
Expand Down
Loading