Skip to content

chore(monorepo-tools): typescriptify package MONGOSH-1498 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2023
Merged

chore(monorepo-tools): typescriptify package MONGOSH-1498 #109

merged 4 commits into from
Jun 30, 2023

Conversation

@addaleax
Copy link
Collaborator

@addaleax addaleax commented Jun 29, 2023

Description

Open Questions

Checklist

Anemy
Anemy approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Left a suggestion and a question, not blockers

I like the simplification with changing forEachPackage to the iterable listallPackages.
typescript 🙌

@addaleax @Anemy
Update packages/monorepo-tools/src/utils/max-increment.ts
b33f6e3 
Co-authored-by: Rhys <Anemy@users.noreply.github.com>
@addaleax addaleax merged commit 2fb5c45 into main Jun 30, 2023
@addaleax addaleax deleted the 1498-dev branch June 30, 2023 14:43
@addaleax addaleax mentioned this pull request Jul 3, 2023
Merged
3 tasks
@lerouxb lerouxb mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addaleax @Anemy