chore(build-info): move and migrate to TypeScript #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/build-info
branch
from
387fc57 to
cb3cb2c
Compare
kraenhansen
commented
Oct 15, 2025
Comment on lines
+138
to
+139
| serverOs: string | null; | ||
| serverArch: string | null; |
Collaborator
Author
There was a problem hiding this comment.
The type declarations didn't include null but the implementation could return it: https://github.com/mongodb-js/mongodb-build-info/blob/cbdfb4ad0bf4e3bfc818cf9e5197ea7345032f72/index.d.ts#L20-L21
This is technically a breaking change, which is fine as I expect to release a major version next 🤞
kraenhansen
commented
Oct 15, 2025
|
|
||
| export function getDataLake(buildInfo: unknown): { | ||
| isDataLake: boolean; | ||
| dlVersion: string | null; |
Collaborator
Author
There was a problem hiding this comment.
Introducing null here to match the former implementation.
This is technically a breaking change, which is fine as I expect to release a major version next 🤞
kraenhansen
commented
Oct 15, 2025
Comment on lines
+83
to
+101
| export const COSMOSDB_BUILD_INFO = { | ||
| _t: 'BuildInfoResponse', | ||
| ok: 1, | ||
| version: '3.2.0', | ||
| gitVersion: '45d947729a0315accb6d4f15a6b06be6d9c19fe7', | ||
| targetMinOS: 'Windows 7/Windows Server 2008 R2', | ||
| modules: [], | ||
| allocator: 'tcmalloc', | ||
| javascriptEngine: 'Chakra', | ||
| sysInfo: 'deprecated', | ||
| versionArray: [3, 2, 0, 0], | ||
| bits: 64, | ||
| debug: false, | ||
| maxBsonObjectSize: 524288, | ||
| openssl: { | ||
| running: 'OpenSSL 1.0.1p-fips 9 Jul 2015', | ||
| compiled: 'OpenSSL 1.0.1p-fips 9 Jul 2015', | ||
| }, | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
Could be deleted as it's not used in the test 🤔
kraenhansen
force-pushed
the
kh/build-info
branch
from
cb3cb2c to
083fe4b
Compare
addaleax
reviewed
Oct 15, 2025
addaleax
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As preparation for COMPASS-9930 I suggest moving the mongodb-build-info package into our shared devtools monorepo and migrate the package to TypeScript in the process.
Once merged, we should archive the original repo.
Open Questions
Checklist