Skip to content

chore: refactor tsconfigs in packages to reuse "include", "exclude" and "outDir" #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 17, 2025
Merged

chore: refactor tsconfigs in packages to reuse "include", "exclude" and "outDir" #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
07051b9
Renamed ./lib to ./dist in download-url
kraenhansen Oct 15, 2025
92a69fb
Removed unneeded special case in build-info
kraenhansen Oct 15, 2025
b3a012c
Removed unused exclude in native-machine-id
kraenhansen Oct 15, 2025
70b03a1
Moved include, exclude and outDir to base tsconfig.
kraenhansen Oct 15, 2025
2434055
Removed unneeded overrides of defaults
kraenhansen Oct 15, 2025
fabfc19
Extend react instead of setting "jsx"
kraenhansen Oct 15, 2025
cfd91c8
Updated the create-workspace script
kraenhansen Oct 15, 2025
4215f7f
Remove unused "allowJs": true
kraenhansen Oct 15, 2025
a7a314a
Remove empty compilerOptions objects
kraenhansen Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion configs/tsconfig-devtools/tsconfig.common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"compilerOptions": {
"outDir": "${configDir}/dist",
"allowJs": false,
"esModuleInterop": true,
"downlevelIteration": true,
Expand All @@ -14,5 +15,7 @@
"sourceMap": true,
"strict": true,
"target": "ES2021"
}
},
"include": ["${configDir}/src/**/*"],
"exclude": ["${configDir}/src/**/*.spec.*"]
}
7 changes: 1 addition & 6 deletions packages/device-id/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
10 changes: 2 additions & 8 deletions packages/devtools-connect/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
"target": "es2020",
"lib": ["es2020", "DOM"],
"module": "commonjs",
"moduleResolution": "node",
"outDir": "./dist",
"allowJs": true,
"strict": true,
"jsx": "react"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"moduleResolution": "node"
}
}
9 changes: 1 addition & 8 deletions packages/devtools-proxy-support/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/dl-center/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
2 changes: 1 addition & 1 deletion packages/download-url/.depcheckrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ ignores:
- '@types/sinon-chai'
- 'sinon'
ignore-patterns:
- 'lib'
- 'dist'
2 changes: 1 addition & 1 deletion packages/download-url/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
.nyc-output
lib
dist
3 changes: 1 addition & 2 deletions packages/download-url/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ npm-debug.log
coverage/

package-lock.json
.esm-wrapper.mjs
lib/
dist/
.nyc_output
tmp-*/
2 changes: 1 addition & 1 deletion packages/download-url/.prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.nyc_output
lib
dist
coverage
2 changes: 1 addition & 1 deletion packages/download-url/bin/mongodb-download-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/usr/bin/env node
require('../lib/bin.js');
require('../dist/bin.js');
14 changes: 7 additions & 7 deletions packages/download-url/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scripts": {
"bootstrap": "npm run compile",
"prepublishOnly": "npm run compile",
"compile": "tsc -p tsconfig.json && gen-esm-wrapper . ./.esm-wrapper.mjs && prettier --write .esm-wrapper.mjs",
"compile": "tsc -p tsconfig.json && gen-esm-wrapper . ./dist/.esm-wrapper.mjs",
Copy link
Collaborator Author

@kraenhansen kraenhansen Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the esm-wrapper into the dist directory like every other package.

"typecheck": "tsc --noEmit",
"eslint": "eslint",
"prettier": "prettier",
Expand All @@ -20,16 +20,16 @@
"test-ci": "npm run test-cov",
"reformat": "npm run prettier -- --write ."
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"exports": {
"require": {
"default": "./lib/index.js",
"types": "./lib/index.d.ts"
"default": "./dist/index.js",
"types": "./dist/index.d.ts"
},
"import": {
"default": "./.esm-wrapper.mjs",
"types": "./lib/index.d.ts"
"default": "./dist/.esm-wrapper.mjs",
"types": "./dist/index.d.ts"
}
},
"bin": {
Expand Down
2 changes: 1 addition & 1 deletion packages/download-url/tsconfig-lint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "./tsconfig.json",
"include": ["**/*"],
"exclude": ["node_modules", "lib"]
"exclude": ["node_modules", "dist"]
}
5 changes: 1 addition & 4 deletions packages/download-url/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "./lib",
"target": "es2019",
"lib": ["es2019"],
"moduleResolution": "node"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
}
}
7 changes: 1 addition & 6 deletions packages/get-os-info/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/mongodb-build-info/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*", "test/**/*"],
"exclude": ["./src/**/*.spec.*", "./test/**/*.ts"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/mongodb-cloud-info/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
7 changes: 1 addition & 6 deletions packages/mongodb-constants/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
7 changes: 1 addition & 6 deletions packages/mongodb-downloader/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true,
"target": "es2020",
"lib": ["es2020"]
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
}
}
7 changes: 1 addition & 6 deletions packages/mongodb-log-writer/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
7 changes: 1 addition & 6 deletions packages/mongodb-ns/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
10 changes: 1 addition & 9 deletions packages/mongodb-redact/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true,
"esModuleInterop": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
7 changes: 1 addition & 6 deletions packages/mongodb-runner/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true,
"target": "es2020",
"lib": ["es2020"]
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
}
}
10 changes: 2 additions & 8 deletions packages/mongodb-ts-autocomplete/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"module": "NodeNext",
"moduleResolution": "NodeNext",
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/types/*"],
Copy link
Collaborator

@addaleax addaleax Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ This exclude isn't kept, right?

I'm a bit confused though, I don't think this worked previously as intended, with two keys of the same name in this file

Copy link
Collaborator Author

@kraenhansen kraenhansen Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - it never worked 🙃 Just tested by reverting this change and tsc --listFiles. Also - even when in the exclude the package source files pull them in.

Copy link
Collaborator

@lerouxb lerouxb Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I probably just messed up.

Copy link
Collaborator

@addaleax addaleax Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it all seems to work 🤷‍♀️ Basically just checking whether we should start to explicitly exclude these files now

"exclude": ["./src/**/*.spec.*"]
"moduleResolution": "NodeNext"
}
}
9 changes: 1 addition & 8 deletions packages/monorepo-tools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/mql-typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
7 changes: 1 addition & 6 deletions packages/native-machine-id/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*", "scripts/benchmark.ts"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/node-webpack-startup-snapshot-checker/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
10 changes: 1 addition & 9 deletions packages/oidc-http-server-pages/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true,
"jsx": "react"
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.react.json"
}
9 changes: 1 addition & 8 deletions packages/oidc-mock-provider/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/query-parser/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/saslprep/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/sbom-tools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/shell-bson-parser/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
9 changes: 1 addition & 8 deletions packages/signing-utils/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json",
"compilerOptions": {
"outDir": "dist",
"allowJs": true,
"strict": true
},
"include": ["src/**/*"],
"exclude": ["./src/**/*.spec.*"]
"extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json"
}
Loading