fix/COMPASS-9956 use more stable key for field component rendering #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm confused as to what is happening in the videos 🙈 Is github automatically converting them to gifs because they're short or do you have control over that? |
Contributor
Author
|
To repro the issue you can on current main create a bunch of fields in the Node and start deleting them from the middle. You will see that the fields are removed from the bottom always |
addaleax
approved these changes
Oct 14, 2025
Contributor
Author
|
Wasn't sure still where a good place for a test would be, but decided I'll just add one in the main diagram test suite |
gribnoysup
commented
Oct 15, 2025
paula-stacho
approved these changes
Oct 15, 2025
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
Weird, I'm not able to reproduce the issue, but I agree the keys are not good as they were
Contributor
Author
|
Well, I have it on (a confusing) record 😈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
When index is being used as a key and a field is removed from the list, react keeps the elemet around with incorrect state (see before / after)
Notes for Reviewers
I don't see any tests for node field updating, so not sure where to add one, but it would be good to merge the fix to get it to compass as this is affecting field editing and expand collapse a lot
📸 Screenshots/Screencasts
Before
After