Skip to content

Conversation

@tadjik1
Copy link
Contributor

@tadjik1 tadjik1 commented Nov 4, 2025

Description

Summary of Changes

Add Node.JS 24.x and latest (25 at the moment) in the matrix for tests to make it similar as we use for other packages.

Notes for Reviewers

I didn't change other actions as they explicitly set LTS version of the Nodejs which effectively becomes 24.x.

What is the motivation for this change?

This change brings testing targets of the package in sync with how other packages are tested (version 24.x is LTS and 25 is "latest").

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 changed the title chore(NODE-7284): add nodej24 in test matrix test(NODE-7284): add nodej24 in test matrix Nov 4, 2025
@tadjik1 tadjik1 marked this pull request as ready for review November 4, 2025 09:27
@tadjik1 tadjik1 requested a review from a team as a code owner November 4, 2025 09:27
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the title, otherwise LGTM

@tadjik1 tadjik1 changed the title test(NODE-7284): add nodej24 in test matrix test(NODE-7284): add Nodejs 24 in test matrix Nov 4, 2025
@dariakp dariakp self-assigned this Nov 5, 2025
@dariakp dariakp merged commit 2a3863e into main Nov 5, 2025
30 checks passed
@dariakp dariakp deleted the NODE-7284 branch November 5, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants