Skip to content

Conversation

@nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Adds release automation tools
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Release automation uniformity

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 20, 2024 18:17
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this May 23, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB self-requested a review May 23, 2024 19:57
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few copy paste problems


const releaseNotes = `${header}

The MongoDB Node.js team is pleased to announce version ${version.version} of the \`mongodb\` package!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The MongoDB Node.js team is pleased to announce version ${version.version} of the \`mongodb\` package!
The MongoDB Node.js team is pleased to announce version ${version.version} of the \`mongodb-connection-string-url\` package!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

* [API](https://mongodb.github.io/node-mongodb-native/${version.major}.${version.minor}/)
* [Changelog](https://github.com/mongodb/node-mongodb-native/blob/v${version.version}/HISTORY.md)

We invite you to try the \`mongodb\` library immediately, and report any issues to the [NODE project](https://jira.mongodb.org/projects/NODE).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We invite you to try the \`mongodb\` library immediately, and report any issues to the [NODE project](https://jira.mongodb.org/projects/NODE).
We invite you to try the \`mongodb-connection-string-url\` library immediately, and report any issues to the [NODE project](https://jira.mongodb.org/projects/NODE).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit f522444 into main May 24, 2024
@nbbeeken nbbeeken deleted the NODE-5389-automate-release branch May 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants