This repository was archived by the owner on May 17, 2021. It is now read-only.
feat: CHARTS-2701 add support for $not with $regex #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now supported as of MongoDB 4.0.7. https://docs.mongodb.com/manual/reference/operator/query/not/index.html#not-and-regular-expressions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now supported as of MongoDB 4.0.7.
https://docs.mongodb.com/manual/reference/operator/query/not/index.html#not-and-regular-expressions
To support this change, we needed to add a special rule that allows
$notto accept aejson_regexright-hand side value.To test, you can also visit https://pegjs.org/online and copy the
./src/grammar.pegjscontent in the left-hand box, then write some queries in the right-hand side box, e.g.I've also added tests for several cases with $regex.