Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented Oct 20, 2025

Proposed changes

  • I updated our clean up job to delete projects and clusters older than 2h, now updating the job to run more frequently

Checklist

@blva blva marked this pull request as ready for review October 20, 2025 10:29
@blva blva requested a review from a team as a code owner October 20, 2025 10:29
Copilot AI review requested due to automatic review settings October 20, 2025 10:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the cleanup GitHub Action to run hourly instead of daily and reduces the default timeout for long-running integration tests.

  • Cron schedule changed from daily to hourly.
  • Long-running test wait timeout reduced from 1,200,000 ms (20 min) to 900,000 ms (15 min).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/integration/helpers.ts Reduced long-running test timeout constant.
.github/workflows/cleanup-atlas-env.yml Updated cron expression to run cleanup hourly.

};

export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 1_200_000;
export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 900_000;
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raw value 900_000 is a magic number and reduces readability; consider expressing it as 15 * 60 * 1000 to make the intended duration (15 minutes) explicit.

Suggested change
export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 900_000;
export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 15 * 60 * 1000; // 15 minutes

Copilot uses AI. Check for mistakes.
@blva blva enabled auto-merge (squash) October 20, 2025 10:45
@blva blva merged commit a8d789b into main Oct 20, 2025
18 of 23 checks passed
@blva blva deleted the atlas-cleanup-frequency branch October 20, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants