Skip to content

chore: update cleanup to run hourly #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

chore: update cleanup to run hourly #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f85bf3c
chore: update cleanup to run hourly
blva Oct 20, 2025
90478e7
update timeout to 15min
blva Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cleanup-atlas-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: "Cleanup stale Atlas test environments"
on:
workflow_dispatch:
schedule:
- cron: "0 0 * * *"
- cron: "0 * * * *"

permissions: {}

Expand Down
2 changes: 1 addition & 1 deletion tests/integration/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const defaultTestConfig: UserConfig = {
loggers: ["stderr"],
};

export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 1_200_000;
export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 900_000;
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raw value 900_000 is a magic number and reduces readability; consider expressing it as 15 * 60 * 1000 to make the intended duration (15 minutes) explicit.

Suggested change
export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 900_000;
export const DEFAULT_LONG_RUNNING_TEST_WAIT_TIMEOUT_MS = 15 * 60 * 1000; // 15 minutes

Copilot uses AI. Check for mistakes.

export function setupIntegrationTest(
getUserConfig: () => UserConfig,
Expand Down
Loading