Skip to content

Conversation

@gagik
Copy link
Collaborator

@gagik gagik commented Oct 24, 2025

Last task failed with:

Error: publish failed: server returned status 400: {"title":"Bad Request","status":400,"detail":"Failed to publish server","errors":[{"message":"registry validation failed for package 1 (docker.io/mongodb/mongodb-mcp-server:1.2.0): OCI packages must not have 'version' field - include version in 'identifier' instead (e.g., 'docker.io/owner/image:1.0.0')"}]}

Unfortunately there doesn't seem to be any --dry-run mode or anything for us to check this without trying to publish first...

@gagik gagik requested a review from a team as a code owner October 24, 2025 10:18
Copilot AI review requested due to automatic review settings October 24, 2025 10:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a publishing error to the MCP Registry by removing the version field from OCI packages in server.json, as the registry requires version information to be included in the identifier field instead. Additionally, the PR separates registry publishing into a dedicated workflow that can be manually triggered.

Key changes:

  • Removed the standalone version field from server.json for OCI packages
  • Updated the script to only set version for non-OCI packages, while OCI packages get their version in the identifier
  • Moved MCP Registry publishing from the main publish workflow to a new dedicated workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
server.json Removed the version field from the packages array to comply with OCI package requirements
scripts/generateArguments.ts Modified to conditionally set version: in the identifier for OCI packages, as a separate field for others
.github/workflows/registry-publish.yml Added new dedicated workflow for manual MCP Registry publishing with GitHub OIDC authentication
.github/workflows/publish.yml Removed MCP Registry publishing steps and bot token setup from the main publish workflow
Comments suppressed due to low confidence (1)

scripts/generateArguments.ts:181

  • The identifier field should remain optional (identifier?: string) rather than required. While OCI packages require an identifier, non-OCI packages may not have one. Making this field required could break compatibility with non-OCI package configurations.
            identifier: string;

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 18776802741

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 80.132%

Totals Coverage Status
Change from base Build 18776177279: -0.006%
Covered Lines: 6297
Relevant Lines: 7718

💛 - Coveralls

@gagik gagik merged commit 5a68122 into main Oct 24, 2025
18 of 19 checks passed
@gagik gagik deleted the gagik/marketplace-server branch October 24, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants