chore: add telemetry properties for vector search and mcp auto-embed usage #796
+201
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshusinghs
added
the
no-title-validation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds telemetry properties to track vector search and auto-embedding feature usage. The changes enable monitoring of preview features configuration and whether MCP server is generating embeddings for vector search operations.
Key Changes:
- Added two new telemetry properties (
previewFeatures,embeddingProviderConfigured) to Server events - Added
embeddingsGeneratedByproperty to Tool events to track auto-embedding usage - Added integration tests to verify telemetry emission for aggregate and insertMany tools
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/telemetry/types.ts | Added new telemetry type definitions and properties for tracking embeddings usage |
| src/server.ts | Added preview features and embedding provider configuration to server event properties |
| src/tools/mongodb/read/aggregate.ts | Implemented telemetry metadata resolution to track auto-embedding usage in aggregation |
| src/tools/mongodb/create/insertMany.ts | Implemented telemetry metadata resolution to track auto-embedding usage in bulk inserts |
| tests/integration/tools/mongodb/read/aggregate.test.ts | Added integration test to verify telemetry emission for auto-embedding in aggregate tool |
| tests/integration/tools/mongodb/create/insertMany.test.ts | Added integration test to verify telemetry emission for auto-embedding in insertMany tool |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Pull Request Test Coverage Report for Build 20167205836Details
💛 - Coveralls |
fmenezes
reviewed
Dec 12, 2025
| read_only_mode?: TelemetryBoolSet; | ||
| disabled_tools?: string[]; | ||
| confirmation_required_tools?: string[]; | ||
| previewFeatures?: string[]; |
Collaborator
There was a problem hiding this comment.
note: while we can add arrays in telemetry, this really makes stuff like amplitude difficult as the values appear as one text with spaces normally.
ordering of strings is also a problem as you can't queries based on keys or position.
since this pattern is already stablished let's proceed, but ideally we should be removing arrays from segment events.
fmenezes
approved these changes
Dec 12, 2025
gagik
reviewed
Dec 12, 2025
gagik
reviewed
Dec 12, 2025
gagik
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the following telemetry properties to Server events:
previewFeatures: Answers what preview features are being enabledembeddingProviderConfigured: Answers whether there is an embedding provider configured or notand adds another property
embeddingsGeneratedByto Tool events to answer whether MCP server auto-embeddings feature is being used or not.Checklist