-
Notifications
You must be signed in to change notification settings - Fork 176
chore: support schema overrides and custom parserOptions MCP-338 #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4b8fe45
5ad2fa4
d90ea39
b9961ab
93ef973
666ab2b
3b4a437
6faa450
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,22 @@ | ||
| export { Server, type ServerOptions } from "./server.js"; | ||
| export { Session, type SessionOptions } from "./common/session.js"; | ||
| export { type UserConfig, UserConfigSchema } from "./common/config/userConfig.js"; | ||
| export { createUserConfig as parseCliArgumentsAsUserConfig } from "./common/config/createUserConfig.js"; | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so I unfortunately missed that we're doing this; it's weird to have this discrepancy where our external export is named differently than our internal one. To me the idea that the name isn't straightforward was a code smell.
It is technically a library breaking change though.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then we anticipate the release with this work will bump major version, correct?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically, yes, though to avoid a major version bump, let's re-export with the old name and mark as deprecated? |
||
| export { parseUserConfig, defaultParserOptions, type ParserOptions } from "./common/config/parseUserConfig.js"; | ||
|
|
||
| import { parseUserConfig } from "./common/config/parseUserConfig.js"; | ||
| import type { UserConfig } from "./common/config/userConfig.js"; | ||
|
|
||
| /** @deprecated Use `parseUserConfig` instead. */ | ||
| export function parseArgsWithCliOptions(cliArguments: string[]): { | ||
| warnings: string[]; | ||
| parsed: UserConfig | undefined; | ||
| error: string | undefined; | ||
| } { | ||
| return parseUserConfig({ | ||
| args: cliArguments, | ||
| }); | ||
| } | ||
|
|
||
| export { LoggerBase, type LogPayload, type LoggerType, type LogLevel } from "./common/logger.js"; | ||
| export { StreamableHttpRunner } from "./transports/streamableHttp.js"; | ||
| export { StdioRunner } from "./transports/stdio.js"; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the concept of CreateUserConfigHelpers was unused.