fix(ci): do not depend on disabled variants in check_coverage MONGOSH-3043 #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI configuration issue where the check_coverage task was incorrectly depending on disabled build variants. The fix ensures that disabled variants are properly excluded from unit test execution.
Key Changes:
- Added a check to filter out disabled variants when selecting unit tests to run
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
approved these changes
Nov 27, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
addaleax
deleted the
check-coverage-should-not-depend-on-disabled-variants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally broken since 4292e4a