Skip to content

Conversation

@addaleax
Copy link
Collaborator

No description provided.

@addaleax addaleax requested a review from a team as a code owner November 27, 2025 12:20
Copilot AI review requested due to automatic review settings November 27, 2025 12:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Node.js REPL bug that affects pasting code in the middle of a line, and updates Node.js version metadata. The bug was introduced in Node.js PR #59857 and fixed in PR #60470. The changes implement a workaround by monkey-patching the REPL's internal methods to correct the line handling behavior when pasting occurs mid-line.

Key changes:

  • Implements fixNode60446() function to detect and work around the REPL paste bug
  • Updates test expectations to accommodate different output formats across Node.js versions
  • Updates Node.js version metadata files (20.19.5 → 20.19.6, Node 24 metadata additions)

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/cli-repl/src/repl-paste-support.ts Adds detection and monkey-patch workaround for Node.js issue #60446
packages/cli-repl/src/repl-paste-support.spec.ts Updates test expectations to handle both old and new REPL output formats; applies fix in test setup
packages/cli-repl/src/mongosh-repl.ts Applies the Node.js bug workaround to the main REPL instance
packages/cli-repl/src/mongosh-repl.spec.ts Adds comprehensive tests for paste functionality in various scenarios
.evergreen/node-24-latest.json Adds missing metadata fields for Node.js 24
.evergreen/node-20-latest.json Updates Node.js 20 version from 20.19.5 to 20.19.6

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 27, 2025
@addaleax addaleax merged commit 82b7196 into main Nov 27, 2025
152 of 154 checks passed
@addaleax addaleax deleted the node-20.19.6 branch November 27, 2025 16:54
@addaleax addaleax mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants