This repository was archived by the owner on Sep 29, 2025. It is now read-only.
Conversation
added 30 commits
August 12, 2025 15:38
added 2 commits
August 25, 2025 15:23
…search_claude-opus-4-20250514_temp_0.9_1755190427429.jsonl
mongodben
commented
Aug 25, 2025
packages/datasets/src/bin/convertNlToMqlDatasetOutToBraintrust.ts
Outdated
Show resolved
Hide resolved
hschawe
approved these changes
Aug 28, 2025
Collaborator
hschawe
left a comment
hschawe
left a comment
There was a problem hiding this comment.
approved, just a couple of small cleanups
...eneration/databaseNlQueries/databaseNodes/generateNaturalLanguageQueries.atlasSearch.eval.ts
Outdated
Show resolved
Hide resolved
| async task(input) { | ||
| const promptMessages = makeGenerateNaturalLanguageQueryPrompt({ | ||
| ...input, | ||
| queryType: "atlas_search", // Ensure we use Atlas Search prompts |
Collaborator
There was a problem hiding this comment.
nit - could make this a named constant since this same string is used twice in this file
| }, | ||
| ] as const satisfies DatabaseUser[]; | ||
|
|
||
| // TODO: update |
Collaborator
There was a problem hiding this comment.
what's to update / should this be removed?
Collaborator
Author
There was a problem hiding this comment.
should be removed. thx
Comment on lines
-258
to
+311
| if ( | ||
| fastestMostFrequentIndex !== null && | ||
| dbExecutions[fastestMostFrequentIndex].data.result !== null | ||
| ) { | ||
| const dbResult = dbExecutions[fastestMostFrequentIndex].data.result; | ||
| if (dbResult && Array.isArray(dbResult) && dbResult.length > 0) { | ||
| dbExecutions[fastestMostFrequentIndex].data.isReferenceAnswer = true; | ||
| if (fastestMostFrequentIndex !== null) { | ||
| const execution = dbExecutions[fastestMostFrequentIndex]; | ||
| if (execution.data.result !== null) { | ||
| const dbResult = execution.data.result; | ||
| if (dbResult && Array.isArray(dbResult) && dbResult.length > 0) { | ||
| execution.data.isReferenceAnswer = true; | ||
| } |
Collaborator
There was a problem hiding this comment.
i prefer the old version of this unless there's a reason to make it more nested
Collaborator
Author
There was a problem hiding this comment.
there were some logic changes in here i believe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-1231
Changes
Notes