This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-32282 API Security #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-olson-mongodb
approved these changes
Aug 25, 2023
Collaborator
sarah-olson-mongodb
left a comment
sarah-olson-mongodb
left a comment
There was a problem hiding this comment.
Thanks @kennethdyer! LGTM
One thing to consider is whether the description is the best place for this info. I noticed the behavior section at the bottom of each page, and thought this might be another good location for this detail. No hard requirements on my end, just a thought. Happy to chat if you have an questions or ideas you wanted to talk through regarding layout.
kennethdyer
force-pushed
the
DOCSP-32282-api-security
branch
from
aa2fb18 to
c8200e5
Compare
kennethdyer
force-pushed
the
DOCSP-32282-api-security
branch
from
03c707f to
ad6e9dd
Compare
edobranov
approved these changes
Apr 2, 2024
Contributor
edobranov
left a comment
edobranov
left a comment
There was a problem hiding this comment.
LGTM!
I just want to point out that on the start page, the Behavior section on the right sidebar doesn't have the sub-sections showing up like the other pages do. I think it'd be nice if they could show up for visibility, but not a big deal otherwise. Thanks!
kennethdyer
force-pushed
the
DOCSP-32282-api-security
branch
from
ad6e9dd to
3c2870b
Compare
kennethdyer
added a commit
to kennethdyer/docs-cluster-to-cluster-sync
that referenced
this pull request
Apr 2, 2024
* DOCSP-32282 Security notice for API calls * Text adjustment * Text adjustment * Adds security notice to other endpoints * Fixes build issue * Fixes build issue * Fixes text * Fixes per Sarah
jeff-allen-mongo
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a notice to each mongosync API endpoint indicating that mongosync does not protect the endpoint, but notes that by default it is bound to localhost only and that it doesn't expose connection details or user data.
Staging
Note added to the descriptions of these pages:
Jira
Build