Skip to content

Conversation

@jeff-allen-mongo
Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo commented Nov 20, 2024

DESCRIPTION

Add a task page for toggling Compass telemetry.

STAGING

Main content is on this new task page: Configure Telemetry Options

I also added links to the new page on these pages:

JIRA

https://jira.mongodb.org/browse/DOCSP-19979

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 4970a46
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/673fb44b6b1ea40008e6912a
😎 Deploy Preview https://deploy-preview-697--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @jeff-allen-mongo ! I left a few comments and questions for your consideration.

Comment on lines 26 to 31
- The type of MongoDB deployment |compass-short| is connected to. For
example, Enterprise Edition, Community Edition, or Atlas Data Lake.

- User actions performed in |compass-short|, such as creating
collections and indexes. |compass-short| only tracks the general
action performed, and does not track field values or namespaces.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] for active voice, although I can see this being a case where passive voice is appropriate

Suggested change
- The type of MongoDB deployment |compass-short| is connected to. For
example, Enterprise Edition, Community Edition, or Atlas Data Lake.
- User actions performed in |compass-short|, such as creating
collections and indexes. |compass-short| only tracks the general
action performed, and does not track field values or namespaces.
- The type of MongoDB deployment that you connect |compass-short| to. For
example, Enterprise Edition, Community Edition, or Atlas Data Lake.
- Actions that you perform in |compass-short|, such as creating
collections and indexes. |compass-short| only tracks the general
action and does not track field values or namespaces.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these suggestions. I think using active voice works here, and this wording is an improvement!

Comment on lines 37 to 43
- IP addresses, hostnames, usernames, or credentials.

- Queries run in |compass-short|.

- Data stored in your MongoDB deployment.

- Personal identifiable information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all of these list items are fragments, I think we can leave out the periods re the style guideline on periods

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

.. procedure::
:style: normal

.. step:: Open the Settings window
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] I would suggest adding a period to all of the step headings

Suggested change
.. step:: Open the Settings window
.. step:: Open the Settings window.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


You can toggle telemetry in either:

- The |compass-short| :ref:`Settings panel <compass-settings-reference>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] is there a reason why this is called the Settings panel in this line but the Settings window below? Is there a way to make this consistent?

Suggested change
- The |compass-short| :ref:`Settings panel <compass-settings-reference>`
- The |compass-short| :ref:`Settings panel <compass-settings-reference>`

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardized to "window".

Comment on lines 92 to 93
.. step:: In the :guilabel:`Settings` window, click :guilabel:`Privacy`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] do you think it would be helpful to add a screenshot of the window here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to omit the screenshot to help future-proof this in the event that the UI changes. I added a bit further clarification to say that "Privacy" is in the left pane of the window, which should hopefully ensure that users can find it.

@jeff-allen-mongo
Copy link
Collaborator Author

@ltran-mdb2 thanks for the review! This is ready for another look whenever you have a chance.


|compass-short| *does not* track:

- IP addresses, hostnames, usernames, or credentials

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually do track the hostname on connection in Compass. We use this information to identify an associated Atlas org when processing our telemetry data.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! Updating.


- IP addresses, hostnames, usernames, or credentials

- Queries run in |compass-short|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will soon start tracking queries generated from the GenAI feature in an anonymized way. Maybe we can reword this so it says we won't be storing queries in a way that can be associated with the user?

Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeff-allen-mongo jeff-allen-mongo merged commit cf8fe0a into mongodb:master Nov 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants