Skip to content

Conversation

@jordan-smith721
Copy link
Collaborator

@jordan-smith721 jordan-smith721 commented Oct 23, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44631
Staging - https://deploy-preview-37--docs-entity-framework.netlify.app/upgrade/#version-8.1.0-breaking-changes

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for docs-entity-framework ready!

Name Link
🔨 Latest commit e541e0f
🔍 Latest deploy log https://app.netlify.com/sites/docs-entity-framework/deploys/671902079874f0000804d83d
😎 Deploy Preview https://deploy-preview-37--docs-entity-framework.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ 1 question


Calling the ``EnsureCreated()`` or ``EnsureCreatedAsync()`` method throws
an error if your application is running on a
:atlas:`shared cluster </reference/free-shared-limitations/>`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making sure this should be "shared cluster" and not "sharded cluster" (assuming so, from the link)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's supposed to be "shared"

@jordan-smith721 jordan-smith721 merged commit 2959c89 into mongodb:master Oct 23, 2024
3 checks passed
@jordan-smith721 jordan-smith721 deleted the DOCSP-44631-ensure-created branch October 23, 2024 16:44
jordan-smith721 added a commit that referenced this pull request Oct 23, 2024
(cherry picked from commit 2959c89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants