DOCSP-46021 - v8.2.1 Release #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-entity-framework ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
damieng
reviewed
Dec 16, 2024
damieng
requested changes
Dec 16, 2024
Member
damieng
left a comment
damieng
left a comment
There was a problem hiding this comment.
Just one clarification but otherwise LGTM
damieng
reviewed
Dec 17, 2024
source/whats-new.txt
Outdated
| .HasCreateIndexOptions(new CreateIndexOptions { Sparse = true }); | ||
| }); | ||
|
|
||
| var result = client.CreateDatabase(context.GetService<IDesignTimeModel>()); |
Member
There was a problem hiding this comment.
Let's replace this last line with context.Database.EnsureCreated();
stephmarie17
approved these changes
Dec 17, 2024
Collaborator
stephmarie17
left a comment
stephmarie17
left a comment
There was a problem hiding this comment.
LGTM from the docs writing side
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit 4f8389c)
mongoKart
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46021
Staging:
Self-Review Checklist