DOCSP-41818 Add Enterprise Authentication page #79
Conversation
✅ Deploy Preview for docs-java-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
left a comment
norareidy
left a comment
There was a problem hiding this comment.
Nice work, left a few comments + a question!
norareidy
left a comment
norareidy
left a comment
There was a problem hiding this comment.
LGTM with a couple small things
| - A connection string | ||
| - A ``MongoCredential`` factory method |
There was a problem hiding this comment.
S: to avoid starting list items with articles:
| - A connection string | |
| - A ``MongoCredential`` factory method | |
| - Connection string | |
| - ``MongoCredential`` factory method |
|
|
||
| To specify the GSSAPI additional properties, include the property in the | ||
| connection string as a URL parameter in the format: | ||
| ``<PROPERTY_NAME>:<value>`` |
There was a problem hiding this comment.
S:
| ``<PROPERTY_NAME>:<value>`` | |
| ``<PROPERTY_NAME>:<value>``. |
jordan-smith721
requested review from
a team and
jyemin
and removed request for
a team
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
There is nothing reactive-specific about any of this, so can I assume it's an exact copy from the sync Java driver? If so, LGTM.
@jyemin yes this is essentially a direct copy from the java sync page, just with edits to the copy to better match our style guide. The actual content and code is the same |
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
I'm sad that we are copying files like this, but LGTM
3 participants
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41818
Staging - https://preview-mongodbjordansmith721.gatsbyjs.io/java-rs/DOCSP-41818-OIDC/security/enterprise-authentication/
Self-Review Checklist