Skip to content

Conversation

@mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Mar 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47975
Staging

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 9a632d6
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/67c6028e74c889000803481d
😎 Deploy Preview https://deploy-preview-1008--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest cleaning up the whats new notes a bit

Comment on lines 48 to 49
- Uses the {+driver-short+}'s ``isUint8Array`` method rather than the ``util/types``
implementation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S; rephrase as this is confusing atm

Comment on lines 51 to 52
- Reverts the version compatibility of ``@aws-sdk/credential-providers`` that was inadvertantly
raised in v6.13.1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Reverts the version compatibility of ``@aws-sdk/credential-providers`` that was inadvertantly
raised in v6.13.1.
- Reverts the version compatibility of ``@aws-sdk/credential-providers`` to ....

@mcmorisi mcmorisi requested a review from rustagir March 3, 2025 19:11
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits but lgtm

The {+driver-short+} v6.14 release includes the following features:

- Adds support for the ``$lookup`` aggregation stage on encrypted collections. You must
upgrade your ``mongodb-client-encryption`` package to v6.3 or later to use this feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S; as they use the full v in the release notes

Suggested change
upgrade your ``mongodb-client-encryption`` package to v6.3 or later to use this feature.
upgrade your ``mongodb-client-encryption`` package to v6.3.0 or later to use this feature.

Comment on lines 48 to 49
- Removes the need to import the ``util/types`` package by specifying the {+driver-short+}'s
internal implementation of the ``isUint8Array`` method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: resolves the vale issue

Suggested change
- Removes the need to import the ``util/types`` package by specifying the {+driver-short+}'s
internal implementation of the ``isUint8Array`` method.
- Uses the driver's implementation of the ``isUint8Array()`` method to prevent
importing the ``util/types`` package.

@mcmorisi mcmorisi merged commit d806fba into mongodb:master Mar 3, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants