Skip to content

Conversation

@ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Apr 18, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-20482
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-20482-typescript-benefits/fundamentals/typescript/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + 2 suggestions

of the MongoDB Node.js driver. TypeScript is a strongly typed programming
language that compiles to JavaScript.

The TypeScript compiler offers error and type checking in real time. Code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: The connection between "error" and "checking" gets lost because of the intervening words. Do you have specific errors in mind that the transpiler catches apart from those found via type checking? If not, I'd suggest just leaving out the error bit:

Suggested change
The TypeScript compiler offers error and type checking in real time. Code
The TypeScript compiler offers type checking in real time. Code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion!

language that compiles to JavaScript.

The TypeScript compiler offers error and type checking in real time. Code
editors that support TypeScript can provide autocomplete, display documentation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: "autocomplete" sounds funny as a direct object

Suggested change
editors that support TypeScript can provide autocomplete, display documentation
editors that support TypeScript can provide autocomplete suggestions, display documentation

@ccho-mongodb ccho-mongodb merged commit f2dc3ee into mongodb:master Apr 18, 2023
@ccho-mongodb ccho-mongodb deleted the DOCSP-20482-typescript-benefits branch April 18, 2023 22:18
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
ccho-mongodb pushed a commit that referenced this pull request Apr 18, 2023
* DOCSP-20482: TypeScript Benefits

(cherry picked from commit f2dc3ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants