-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-20482: TypeScript Benefits #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-20482: TypeScript Benefits #663
Conversation
mongoKart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm + 2 suggestions
source/fundamentals/typescript.txt
Outdated
| of the MongoDB Node.js driver. TypeScript is a strongly typed programming | ||
| language that compiles to JavaScript. | ||
|
|
||
| The TypeScript compiler offers error and type checking in real time. Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: The connection between "error" and "checking" gets lost because of the intervening words. Do you have specific errors in mind that the transpiler catches apart from those found via type checking? If not, I'd suggest just leaving out the error bit:
| The TypeScript compiler offers error and type checking in real time. Code | |
| The TypeScript compiler offers type checking in real time. Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion!
source/fundamentals/typescript.txt
Outdated
| language that compiles to JavaScript. | ||
|
|
||
| The TypeScript compiler offers error and type checking in real time. Code | ||
| editors that support TypeScript can provide autocomplete, display documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: "autocomplete" sounds funny as a direct object
| editors that support TypeScript can provide autocomplete, display documentation | |
| editors that support TypeScript can provide autocomplete suggestions, display documentation |
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
* DOCSP-20482: TypeScript Benefits (cherry picked from commit f2dc3ee)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-20482
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-20482-typescript-benefits/fundamentals/typescript/
Self-Review Checklist