DOCSP-44256 Add Kubernetes Support for OIDC #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
approved these changes
Dec 13, 2024
Collaborator
mongoKart
left a comment
mongoKart
left a comment
There was a problem hiding this comment.
LGTM w/ 1 suggestion. Nice job!
Collaborator
There was a problem hiding this comment.
I can't add a comment on the line, but can you change :depth: to 2 at the top of the page? That way, the different OIDC options appear in the TOC on the right.
nbbeeken
reviewed
Dec 16, 2024
Collaborator
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
super small nit, otherwise lgtm
| .. code-block:: js | ||
| :emphasize-lines: 3-4 | ||
|
|
||
| const { MongoClient } = require("mongodb"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const { MongoClient } = require("mongodb"); | |
| import { MongoClient } from "mongodb"; |
minor, but we should use the modern import syntax in our snippets
rustagir
pushed a commit
that referenced
this pull request
Jan 21, 2025
* DOCSP-44256 Add Kubernetes Support for OIDC * edits and remove monospace from titles * change depth to 2 * tech review fix for import (cherry picked from commit 3e0e04e)
rustagir
pushed a commit
that referenced
this pull request
Jan 21, 2025
* DOCSP-44256 Add Kubernetes Support for OIDC * edits and remove monospace from titles * change depth to 2 * tech review fix for import (cherry picked from commit 3e0e04e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44256
Staging - https://deploy-preview-950--docs-node.netlify.app/fundamentals/authentication/enterprise-mechanisms/#kubernetes
Self-Review Checklist