DOCSP-35346: Change parse method #104
Conversation
jordan-smith721
left a comment
jordan-smith721
left a comment
There was a problem hiding this comment.
Just a couple clarifying questions
| // Replace the placeholder with your Atlas connection string | ||
| let uri = "<connection string>"; | ||
| let mut client_options = ClientOptions::parse(uri)?; | ||
| let mut client_options = ClientOptions::parse_async(uri)?; |
There was a problem hiding this comment.
Question: I noticed this is in the connection-sync file and doesn't have .await?, should this stay as just parse?
There was a problem hiding this comment.
Thanks for catching - yes I meant to leave as is for all the sync files! So this can stay as parse()
| let uri = "<connection string>"; | ||
| // start-stable-api-behavior | ||
| let mut client_options = ClientOptions::parse(uri)?; | ||
| let mut client_options = ClientOptions::parse_async(uri)?; |
There was a problem hiding this comment.
Similar question to above, since there is no await here, should it stay parse instead? Or maybe add the await call?
There was a problem hiding this comment.
This is also a sync file so you're right, this can stay parse()
| fn main() -> mongodb::error::Result<()> { | ||
| let uri = "<connection string>"; | ||
| let mut client_options = ClientOptions::parse(uri)?; | ||
| let mut client_options = ClientOptions::parse_async(uri)?; |
There was a problem hiding this comment.
Same question as above, since there is no await here, should it stay parse instead? Or maybe add the await call?
(cherry picked from commit 9cc0cca)
(cherry picked from commit 9cc0cca)
2 participants
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-35346
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/rust/DOCSP-35346-parse-method/
Self-Review Checklist