DOCSP-33478: fix vale issues #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norareidy
approved these changes
Jan 23, 2024
Collaborator
norareidy
left a comment
norareidy
left a comment
There was a problem hiding this comment.
LGTM + a couple suggestions
source/fundamentals/aggregation.txt
Outdated
| ``genre_interests`` field. This stage finds the average, minimum, and | ||
| maximum user age for users, using the ``$avg``, ``$min``, and ``$max`` | ||
| operators, respectively. | ||
| maximum user age for users, by using the ``$avg``, ``$min``, and ``$max`` |
Collaborator
There was a problem hiding this comment.
S: "user age for users" is slightly repetitive; also I don't think you need a comma before "by"
Suggested change
| maximum user age for users, by using the ``$avg``, ``$min``, and ``$max`` | |
| maximum user age by using the ``$avg``, ``$min``, and ``$max`` |
| ``RUST_LOG`` to one of the targets provided in the preceding table, | ||
| along with a severity level. | ||
| ``RUST_LOG`` to one of the targets provided in the preceding table and | ||
| specifying a severity level. |
Collaborator
There was a problem hiding this comment.
S: [nit] just to avoid repeating "specify"
Suggested change
| specifying a severity level. | |
| including a severity level. |
rustagir
added a commit
that referenced
this pull request
Jan 23, 2024
(cherry picked from commit 118e6f6)
rustagir
added a commit
that referenced
this pull request
Jan 23, 2024
(cherry picked from commit 118e6f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-33478
Staging
Self-Review Checklist