Skip to content

Conversation

@ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Jan 24, 2024

Pull Request Info

PR Reviewing Guidelines

Updated a couple page links that were commented out of the Fundamentals item bulleted list.
Updated the REVIEWING.md to clarify when to seek technical reviews.

JIRA - None
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- :ref:`Record Driver Events <rust-tracing-logging>`
- :ref:`Run A Database Command <rust-run-command>`
- :ref:`Specify Collations to Order Results <rust-collations>`
- :ref:`Optimize Driver Performance <rust-performance>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: nit while you are editing this file, could you move Collations to the correct position to match the way that it appears in the drawer?

@ccho-mongodb ccho-mongodb merged commit 014ec5c into mongodb:master Jan 24, 2024
@ccho-mongodb ccho-mongodb deleted the 012424-add-missing-list-items branch January 24, 2024 19:45
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2024
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants