DOCSP-55528: Add filtering to frontend and JS backend#69
Merged
cbullinger merged 3 commits intofeature/filteringfrom Jan 14, 2026
Merged
DOCSP-55528: Add filtering to frontend and JS backend#69cbullinger merged 3 commits intofeature/filteringfrom
cbullinger merged 3 commits intofeature/filteringfrom
Conversation
jordan-smith721
approved these changes
Jan 14, 2026
Collaborator
jordan-smith721
left a comment
jordan-smith721
left a comment
There was a problem hiding this comment.
Looks great! Just a couple small things
| export async function fetchGenres(): Promise<string[]> { | ||
| try { | ||
| const response = await fetch(`${API_BASE_URL}/api/movies/genres`, { | ||
| next: { revalidate: 3600 }, // Cache genres for 1 hour since they rarely change |
Collaborator
There was a problem hiding this comment.
Probably not an issue to keep this, but I don't think caching and revalidating is necessary here since we don't expect genres to change at all for this app
Collaborator
Author
There was a problem hiding this comment.
I'd prefer to keep it in since folks can modify and define their own genres with the app, which would potentially change the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC for basic filtering to demonstrate
find(). Filter persists in URL.Can filter by:
Sort results by: