Get rid of lombok @Data annotation#96
Merged
cbullinger merged 12 commits intomongodb:developmentfrom Apr 15, 2026
Merged
Conversation
…during `./mvnw clean spring-boot:run`. Introduce better way to exclude lombok jars from the build artefacts.
…ll not be setup properly
Remove duplicate lombok dependency, merge the two maven-compiler-plugin
blocks, drop redundant source/target/encoding settings inherited from
spring-boot-starter-parent, and pin the annotation processor version
via ${lombok.version}.
…-lombok-data-annotation
Replace compact constructors in SuccessResponse and ErrorResponse with partial builder class declarations to provide proper defaults, and remove now-redundant .success() and .timestamp() calls from all builder sites. Use @with for DirectorStatisticsResult.averageRating to match the pattern in MoviesByYearResult. Expand wildcard lombok import in Movie.
…sors Add @tostring(onlyExplicitlyIncluded = true) to Movie, including id, title, and year for meaningful debug output. Rename ApiResponse methods from JavaBean style (isSuccess/getTimestamp) to record accessor style (success/timestamp) and drop the bridge methods from ErrorResponse and SuccessResponse since records already generate matching accessors.
…d style Restore @AllArgsConstructor/@NoArgsConstructor(access = PROTECTED) on Awards, Imdb, Tomatoes, Viewer, and Critic so Spring Data MongoDB can reliably instantiate them without depending on compiler debug info. Normalise record declaration spacing and replace FQN java.util.List with an import in VectorSearchResult.
cbullinger
approved these changes
Apr 15, 2026
Collaborator
cbullinger
left a comment
cbullinger
left a comment
There was a problem hiding this comment.
LGTM, thanks for implementing this refactor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: This PR should be reviewed after #95 is reviewed and merged as it is stacked on it.
@Getterand@Setterfor MongoDB@Document@Builderis already used